Skip to content

Split automated command into two make calls #3168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

ericvn
Copy link
Contributor

@ericvn ericvn commented Feb 1, 2021

An update in istio/common-files#382 was propagated to the various repos via the automation script. The automated PR included changes in go.sum where the common-files update should have changed the makefile target, mod-download-go, to prevent that. Some experimentation running make update-common gen in a build container showed that indeed the go.sum file was changed. This did not happen when running the command from the command line. Splitting the command into two makes in the build container did not update the go.sum.

A subsequent common-files update (remove the target and make the mod-download-go rule do nothing will hopefully get the automated PRs corrected and merged.

@ericvn ericvn requested a review from a team as a code owner February 1, 2021 13:38
@google-cla google-cla bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Feb 1, 2021
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 1, 2021
@istio-testing istio-testing merged commit f29cbf6 into istio:master Feb 1, 2021
@istio-testing
Copy link
Collaborator

@ericvn: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key istio.common-files.master.gen.yaml using file prow/cluster/jobs/istio/common-files/istio.common-files.master.gen.yaml

In response to this:

An update in istio/common-files#382 was propagated to the various repos via the automation script. The automated PR included changes in go.sum where the common-files update should have changed the makefile target, mod-download-go, to prevent that. Some experimentation running make update-common gen in a build container showed that indeed the go.sum file was changed. This did not happen when running the command from the command line. Splitting the command into two makes in the build container did not update the go.sum.

A subsequent common-files update (remove the target and make the mod-download-go rule do nothing will hopefully get the automated PRs corrected and merged.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ericvn ericvn deleted the splitCommonFileAutomate branch February 1, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants