Split automated command into two make calls #3168
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An update in istio/common-files#382 was propagated to the various repos via the automation script. The automated PR included changes in go.sum where the common-files update should have changed the makefile target, mod-download-go, to prevent that. Some experimentation running
make update-common gen
in a build container showed that indeed the go.sum file was changed. This did not happen when running the command from the command line. Splitting the command into two makes in the build container did not update the go.sum.A subsequent common-files update (remove the target and make the
mod-download-go
rule do nothing will hopefully get the automated PRs corrected and merged.