Skip to content

Update yargs-parser #1133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2022
Merged

Update yargs-parser #1133

merged 1 commit into from
Aug 19, 2022

Conversation

0x2b3bfa0
Copy link
Member

Closes #852 🎉

@0x2b3bfa0 0x2b3bfa0 added bug Something isn't working p1-important High priority cml-runner Subcommand labels Aug 19, 2022
@0x2b3bfa0 0x2b3bfa0 requested a review from a team August 19, 2022 13:12
@0x2b3bfa0 0x2b3bfa0 self-assigned this Aug 19, 2022
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal August 19, 2022 13:12 Inactive
dacbd added a commit to iterative/cml-playground that referenced this pull request Aug 19, 2022
@dacbd
update for iterative/cml#1133
00ba779
dacbd
dacbd suggested changes Aug 19, 2022
View reviewed changes
Copy link
Contributor

@dacbd dacbd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im assuming this is supposed to allow: --cloud-ssh-private="$(cat ./key.pem)" instead of --cloud-ssh-private="$(cat ./key.pem) " which doesnt appear to be the case.

@0x2b3bfa0
Copy link
Member Author

@dacbd, sounds like a stray space character in your test workflow:

- --labels=private-key-852 -test 
+ --labels=private-key-852-test

@0x2b3bfa0 0x2b3bfa0 requested a review from dacbd August 19, 2022 16:08
@dacbd
Copy link
Contributor

dacbd commented Aug 19, 2022

indeed

dacbd
dacbd approved these changes Aug 19, 2022
View reviewed changes
Copy link
Contributor

@dacbd dacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test fixed, and passes

@0x2b3bfa0 0x2b3bfa0 merged commit a07a528 into master Aug 19, 2022
@0x2b3bfa0 0x2b3bfa0 deleted the walktheplank branch August 19, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@dacbd dacbd dacbd approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@0x2b3bfa0 0x2b3bfa0

Labels
bug Something isn't working cml-runner Subcommand p1-important High priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

difficult to set --cloud-ssh-private
2 participants
@0x2b3bfa0 @dacbd