Skip to content

hashfile.tree: implement update_tree #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

hashfile.tree: implement update_tree #344

wants to merge 1 commit into from

Conversation

skshetry
Copy link
Collaborator

@skshetry skshetry commented May 1, 2023

I am still thinking of what the high-level API should be for building these upserted files.

We need a way to build the files, with possible expansion of directories/prefixes and ignores applied. Also, would be nice to have a batched build functionality.

But since, build() is already complicated, I'm still thinking of other options for now.
So, I have only created a low-level helper to update a tree.

Related to iterative/dvc#4657.

@skshetry skshetry requested review from pmrowla and efiop May 1, 2023 13:17
@skshetry skshetry changed the title [WIP] hashfile.tree: implement update_tree hashfile.tree: implement update_tree May 1, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 1, 2023

Codecov Report

Patch coverage: 18.18% and project coverage change: -0.15 ⚠️

Comparison is base (a2f9ed9) 57.82% compared to head (6c00c1c) 57.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #344      +/-   ##
==========================================
- Coverage   57.82%   57.67%   -0.15%     
==========================================
  Files          51       51              
  Lines        3395     3405      +10     
  Branches      595      596       +1     
==========================================
+ Hits         1963     1964       +1     
- Misses       1346     1355       +9     
  Partials       86       86              
Impacted Files Coverage Δ
src/dvc_data/hashfile/tree.py 53.07% <18.18%> (-1.98%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@skshetry
Copy link
Collaborator Author

skshetry commented May 2, 2023

Closing for now, will reopen later if I need it.

@skshetry skshetry closed this May 2, 2023
@skshetry skshetry deleted the update-tree branch May 2, 2023 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants