Skip to content

hashfile.tree: add as_trie/from_trie #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2023
Merged

hashfile.tree: add as_trie/from_trie #345

merged 1 commit into from
May 5, 2023

Conversation

skshetry
Copy link
Collaborator

@skshetry skshetry commented May 2, 2023

Related to iterative/dvc#4657.

Using it in https://github.com/iterative/dvc/pull/9389/files to prune subtree and add items to the trie and rebuild tree out of it.

@skshetry skshetry requested a review from efiop May 2, 2023 10:39
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.04 ⚠️

Comparison is base (a2f9ed9) 57.82% compared to head (1c225cc) 57.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #345      +/-   ##
==========================================
- Coverage   57.82%   57.78%   -0.04%     
==========================================
  Files          51       51              
  Lines        3395     3402       +7     
  Branches      595      596       +1     
==========================================
+ Hits         1963     1966       +3     
- Misses       1346     1350       +4     
  Partials       86       86              
Impacted Files Coverage Δ
src/dvc_data/hashfile/tree.py 54.66% <50.00%> (-0.38%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@skshetry skshetry merged commit a57ed24 into main May 5, 2023
@skshetry skshetry deleted the as-from-trie branch May 5, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants