Skip to content

introduce repo concept, make plumbing CLI available as dvc-data command #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2022

Conversation

skshetry
Copy link
Collaborator

@skshetry skshetry commented Jul 4, 2022

We need to introduce repo concept so that the plumbing CLI command
is compatible with dvc init created repositories.

CLi command will try to discover .dvc directory. You can alternatively specify DVC_DIR envvar in which case it'll consider your current working directory as root and will use DVC_DIR as an object_dir and tmp directory for state.

This change makes it compatible with dvc-created repositories.

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2022

Codecov Report

Merging #82 (1e62138) into main (ba69bf6) will decrease coverage by 4.84%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
- Coverage   34.44%   29.60%   -4.85%     
==========================================
  Files          33       36       +3     
  Lines        1675     1949     +274     
  Branches      301      359      +58     
==========================================
  Hits          577      577              
- Misses       1085     1358     +273     
- Partials       13       14       +1     
Impacted Files Coverage Δ
src/dvc_data/__main__.py 0.00% <0.00%> (ø)
src/dvc_data/cli.py 0.00% <0.00%> (ø)
src/dvc_data/repo.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba69bf6...1e62138. Read the comment docs.

We need to introduce repo concept so that the plumbing CLI command
is compatible with `dvc init` created repositories.
@efiop efiop merged commit 19b31de into main Jul 9, 2022
@skshetry skshetry deleted the data-repo branch July 9, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants