fs.get_missing_deps: use find_spec to check if packages are missing instead of importing them #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skshetry
requested review from
a team and
karajan1001
and removed request for
a team
…s are missing instead of importing from them This speeds up `dvc version` from >1s to ~0.35s in my machine.
skshetry
force-pushed
the
use-find-spec
branch
from
012b527 to
1c8f237
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up
dvc versionfrom >1s to ~0.35s in my machine.See https://docs.python.org/3/library/importlib.html#checking-if-a-module-can-be-imported.