Skip to content

[accessibility] hide the mobile menu on desktop from keyboard users. #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2020
Merged

[accessibility] hide the mobile menu on desktop from keyboard users. #1170

merged 1 commit into from
Apr 19, 2020

Conversation

nisarhassan12
Copy link
Contributor

Fixes the following from #1149

image

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-hide-menu-zp2dub1q April 19, 2020 18:43 Inactive
@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Apr 19, 2020

This is hard to check on https://dvc-landing-hide-menu-zp2dub1q.herokuapp.com/ because it doesn't include the focus visibility from #1153 so Idk where I am after every tab. But it seems like it's working.

Please request our review again after #1153 is merged into master and then master into here 🙂

@shcheklein shcheklein merged commit 03c199a into iterative:master Apr 19, 2020
@jorgeorpinel
Copy link
Contributor

Hey guys. There's a similar problem in https://dvc.org/doc: Once you get to the left sidebar with tabs, it seems to traverse all the collapsed (hidden) items. Should I open a specific issue for that or do you want to send a PR directly perhaps, @nisarhassan12?

@nisarhassan12
Copy link
Contributor Author

Thanks! @jorgeorpinel I would send a Pr directly.

@nisarhassan12
Copy link
Contributor Author

Hey guys. There's a similar problem in https://dvc.org/doc: Once you get to the left sidebar with tabs, it seems to traverse all the collapsed (hidden) items. Should I open a specific issue for that or do you want to send a PR directly perhaps, @nisarhassan12?

@jorgeorpinel someone else can work on this.

@jorgeorpinel
Copy link
Contributor

Sure np, thanks @nisarhassan12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants