Skip to content

checkout example is simplified by using fetch #1340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 25, 2020

Conversation

imhardikj
Copy link
Contributor

@imhardikj imhardikj commented May 23, 2020

This PR updates \content\docs\commands-reference\checkout.md to fix #528 (comment).
checkout example is simplified by using 'dvc fetch`.


Some specific subtasks:

  • cmd ref: use example-get-started repo in pull examples #528 (comment):

    dvc fetch could be hidden in the "Click and expand to setup the project"...

  • cmd ref: use example-get-started repo in pull examples #528 (comment):

    fetch -aT is not currently used in the expandable section. The suggestion is to add it there so it can be removed from the block further down. There's an explanation about it under that block too, which would probably need to go away (moved into the expandable section too).

  • &

    However the fetch + checkout parenthesis would have to go away too (not moved, just gone). Instead maybe we can just link "fetch" and "checkout" in We can now just run dvc pull that will fetch and checkout the...

Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff so far, thanks! Needs a little bit of polishing details.

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented May 24, 2020

Hi. I noticed you pushed a commit @imhardikj is this ready to re-review? Please request so when ready from the top of the PR:

image

@imhardikj imhardikj requested a review from jorgeorpinel May 24, 2020 20:47
@imhardikj
Copy link
Contributor Author

@jorgeorpinel I missed to make a review request. If the changes in checkout are correct can I proceed to work on pull example.

Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more suggestion but otherwise this is good!

@shcheklein shcheklein merged commit 84f693a into iterative:master May 25, 2020
@imhardikj imhardikj changed the title use example-get-started repo in pull examples checkout example is simplified by using fetch May 26, 2020
@imhardikj imhardikj deleted the dvc-pull branch May 27, 2020 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmd ref: use example-get-started repo in pull examples
3 participants