Skip to content

use example-get-started repo in pull examples #1365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 31, 2020

Conversation

imhardikj
Copy link
Contributor

This PR updates \content\docs\commands-reference\pull.md to fix #528.
Example-get-started repo is used in pull examples to show simplified usage of dvc pull.

Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Review for first part of examples:

Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review for the 2nd example:

Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This last review I'll just apply myself, as it relates to the existing example.

Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more things I plan to apply myself ☝️

@jorgeorpinel
Copy link
Contributor

To summarize, just one thing is missing here: #1365 (comment) Thanks!

@imhardikj imhardikj requested a review from jorgeorpinel May 30, 2020 12:36
@jorgeorpinel jorgeorpinel merged commit c5a6e75 into iterative:master May 31, 2020
@jorgeorpinel
Copy link
Contributor

Another good one @imhardikj thank you so much!

We still have one week before the next stage of GSoD starts so if there's any topics that interest you particularly about DVC and you find some existing or new issues with them, feel free to continue contributing but no pressure. Let's coordinate about the project idea preparation when you're ready, please ping me via email or Discord.

Thanks

@imhardikj imhardikj deleted the dvc-pull branch June 8, 2020 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmd ref: use example-get-started repo in pull examples
2 participants