-
Notifications
You must be signed in to change notification settings - Fork 398
Restyle 2.0 Pipelines ("parametrization") #2054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
content/docs/user-guide/dvc-files.md
Outdated
- >- # YAML multiline string block | ||
python ${train.script} | ||
--out model.pkl | ||
--thresh ${train.thresh} | ||
python ${train.script} --out model.pkl --thresh ${train.thresh} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, I think I want to keep that YAML Block Chomp... If not in this doc, in a coming one.
Why is this invalid for Prettier? Thoughts @rogermparent ? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is due to the proseWrap: always
setting that we have in .prettierrc
as opposed to the default preserve
. I've run into issues with always
before, particularly with custom components.
Switching to preserve
would solve both of these issues, and proseWrap
only affects MD files so the impact won't make unintended changes to prettier rules in actual code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rogermparent I applied the change in 5cffe8c and that automatically closed this PR. Let's see how that goes 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prettier rules are important for MD. We consider MD as part of code. What are the consequences of changing it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not much (it seems). See #2060
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since everything is already formatted this experiment only proves that it preserves most of the things. The question is how does it behave in different "broken" cases.
88c5b38
to
7e87239
Compare
7e87239
to
af1cc39
Compare
af1cc39
to
3656b68
Compare
3656b68
to
f3aa236
Compare
2cae823
to
add7d65
Compare
f3aa236
to
d27c450
Compare
d27c450
to
e69538d
Compare
Automated style fixes for #2052, created by Restyled.
The following restylers made fixes:
To incorporate these changes, merge this Pull Request into the original. We
recommend using the Squash or Rebase strategies.
NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.
Sorry if this was unexpected. To disable it, see our documentation.