Skip to content

Restyle 2.0 Pipelines ("parametrization") #2054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

restyled-io[bot]
Copy link
Contributor

@restyled-io restyled-io bot commented Dec 24, 2020

Automated style fixes for #2052, created by Restyled.

The following restylers made fixes:

  • prettier

To incorporate these changes, merge this Pull Request into the original. We
recommend using the Squash or Rebase strategies.

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.

@shcheklein shcheklein temporarily deployed to dvc-landing-restyled-2--nipmov December 24, 2020 04:46 Inactive
Comment on lines 155 to 158
- >- # YAML multiline string block
python ${train.script}
--out model.pkl
--thresh ${train.thresh}
python ${train.script} --out model.pkl --thresh ${train.thresh}
Copy link
Contributor

@jorgeorpinel jorgeorpinel Dec 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, I think I want to keep that YAML Block Chomp... If not in this doc, in a coming one.

Why is this invalid for Prettier? Thoughts @rogermparent ? Thanks!

Copy link
Contributor

@rogermparent rogermparent Dec 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is due to the proseWrap: always setting that we have in .prettierrc as opposed to the default preserve. I've run into issues with always before, particularly with custom components.

Switching to preserve would solve both of these issues, and proseWrap only affects MD files so the impact won't make unintended changes to prettier rules in actual code.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rogermparent I applied the change in 5cffe8c and that automatically closed this PR. Let's see how that goes 🙂

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prettier rules are important for MD. We consider MD as part of code. What are the consequences of changing it?

Copy link
Contributor

@jorgeorpinel jorgeorpinel Dec 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much (it seems). See #2060

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since everything is already formatted this experiment only proves that it preserves most of the things. The question is how does it behave in different "broken" cases.

@restyled-io restyled-io bot force-pushed the restyled/2.0/pipelines branch from 88c5b38 to 7e87239 Compare December 27, 2020 00:41
@shcheklein shcheklein temporarily deployed to dvc-landing-restyled-2--nipmov December 27, 2020 00:42 Inactive
@restyled-io restyled-io bot force-pushed the restyled/2.0/pipelines branch from 7e87239 to af1cc39 Compare December 27, 2020 03:23
@shcheklein shcheklein temporarily deployed to dvc-landing-restyled-2--nipmov December 27, 2020 03:23 Inactive
@restyled-io restyled-io bot force-pushed the restyled/2.0/pipelines branch from af1cc39 to 3656b68 Compare December 27, 2020 05:16
@shcheklein shcheklein temporarily deployed to dvc-landing-restyled-2--nipmov December 27, 2020 05:16 Inactive
@restyled-io restyled-io bot force-pushed the restyled/2.0/pipelines branch from 3656b68 to f3aa236 Compare December 27, 2020 05:17
@shcheklein shcheklein temporarily deployed to dvc-landing-restyled-2--nipmov December 27, 2020 05:18 Inactive
@restyled-io restyled-io bot force-pushed the restyled/2.0/pipelines branch from f3aa236 to d27c450 Compare December 27, 2020 05:29
@shcheklein shcheklein temporarily deployed to dvc-landing-restyled-2--nipmov December 27, 2020 05:29 Inactive
@restyled-io restyled-io bot force-pushed the restyled/2.0/pipelines branch from d27c450 to e69538d Compare December 27, 2020 20:28
@shcheklein shcheklein temporarily deployed to dvc-landing-restyled-2--nipmov December 27, 2020 20:28 Inactive
@restyled-io restyled-io bot closed this Dec 27, 2020
@restyled-io restyled-io bot deleted the restyled/2.0/pipelines branch December 27, 2020 23:41
jorgeorpinel added a commit that referenced this pull request Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants