cli: add: add an --output argument #2101
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow users to add files from outside of the repo. This is a first step toward achieving iterative/dvc#4657.
mrstegeman
added a commit
to mrstegeman/dvc
that referenced
this pull request
Jan 18, 2021
Allow users to add files from outside of the repo. This is a first step toward achieving iterative#4657. References iterative/dvc.org#2101
2 tasks
Comment on lines
+154
to
+155
| - `-o`, `--output` - adds the `<target>` file from outside the repo to the repo | ||
| at the specified `<path>`. |
There was a problem hiding this comment.
Quick copy edit:
Suggested change
| - `-o`, `--output` - adds the `<target>` file from outside the repo to the repo | |
| at the specified `<path>`. | |
| - `-o <path>`, `--output <path>` - adds a single external target (file or | |
| directory) to the specified `path`. |
There was a problem hiding this comment.
But TBH I don't quite understand what this option does from this text.
There was a problem hiding this comment.
In any case (as mentioned in iterative/dvc#5284 (review)) the same(?) option is being introduced separately, explained differently in #2091:
-o <path>,--out <path>- destination path for the transferred data (can
only be used with--to-remote).
Is it the same concept? Thanks
jorgeorpinel
added
the
⌛ status: wait-core-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to add files from outside of the repo. This is a first
step toward achieving iterative/dvc#4657.
References iterative/dvc#5284
❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.
🐛 Please make sure to mention
Fix #issue(if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.Please choose to allow us to edit your branch when creating the PR.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏