Skip to content

DOC: dvc import can access non-DVC Git repositories #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

DOC: dvc import can access non-DVC Git repositories #900

wants to merge 4 commits into from

Conversation

chatcannon
Copy link

@chatcannon chatcannon commented Jan 6, 2020

Updating the command reference for the changes in
iterative/dvc#3020

Fixes #898

Updating the command reference for the changes in
iterative/dvc#3020
@shcheklein
Copy link
Member

@chatcannon thanks! does it affect dvc get command as well?

@jorgeorpinel
Copy link
Contributor

@shcheklein I think this was already implemented for dvc get before, see iterative/dvc/pull/2837. And its cmd ref already reflects this.

Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Please try to compare the whole doc vs. https://dvc.org/doc/command-reference/get to see if there's any other relevant changes 🙂

@jorgeorpinel

This comment has been minimized.

@shcheklein
Copy link
Member

@jorgeorpinel let's take it over, fix what's left and merge

@chatcannon
Copy link
Author

The 'prettier' tool is failing (with no information as to why) and I can't be bothered to faff around installing npm and all that mess just to format my code. Someone else do it please.

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Jan 19, 2020

All the checks are passing actually :suspect: Also, the formatting hooks are installed automatically with Yarn. This is a Node project after all, pretty quick to run a package manager... But anyway, feel free to unsubs, I got this one 🙂

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Jan 19, 2020

He guys actually after Chris merged from master not many changes are left in the PR. I guess we already did most of this in another recent PR. I'm closing it but will review each commit to make sure nothing was missed. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmd ref: update import: it now supports non-DVC Git repos
3 participants