Skip to content

dvc: unify class naming #2089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
efiop opened this issue Jun 4, 2019 · 7 comments · Fixed by #3684
Closed

dvc: unify class naming #2089

efiop opened this issue Jun 4, 2019 · 7 comments · Fixed by #3684
Labels
enhancement Enhances DVC p3-nice-to-have It should be done this or next sprint refactoring Factoring and re-factoring

Comments

@efiop
Copy link
Contributor

efiop commented Jun 4, 2019

E.g. RemoteS3 -> S3Remote, DependencyS3 -> S3Dependency, etc.
@efiop efiop added refactoring Factoring and re-factoring enhancement Enhances DVC p3-nice-to-have It should be done this or next sprint labels Jun 4, 2019
@nik123
Copy link
Contributor

nik123 commented Apr 25, 2020

Is it still relevant? May I implement it?

@efiop
Copy link
Contributor Author

efiop commented Apr 25, 2020

Hi @nik123 !

Sure! 🙏 Could start with start with unifying Remote* class names. You can find all of them in dvc/remote/ dir. We should follow pep8 with those.

nik123 added a commit to nik123/dvc that referenced this issue Apr 26, 2020
@nik123
refactor: dvc/remotes name unification
734f7cd 
Partially fixes iterative#2089
@nik123 nik123 mentioned this issue Apr 26, 2020
Merged
@nik123
Copy link
Contributor

nik123 commented Apr 26, 2020

@efiop deepsource says that several abstract methods of BaseRemote are not implemented in subclasses. Should they be implemented as well as a part of this issue?

efiop pushed a commit that referenced this issue Apr 26, 2020
@nik123
refactor: dvc/remotes name unification (#3684)
fefbcc0 
Partially fixes #2089
@efiop
Copy link
Contributor Author

efiop commented Apr 26, 2020

Keeping open for other classes.

@efiop efiop reopened this Apr 26, 2020
@efiop
Copy link
Contributor Author

efiop commented Apr 26, 2020

@efiop deepsource says that several abstract methods of BaseRemote are not implemented in subclasses. Should they be implemented as well as a part of this issue?

@nik123 Not really, this one is purely about naming. Could do that one later too, though 😉

This was referenced Apr 28, 2020
Merged
Merged
@nik123
Copy link
Contributor

nik123 commented Apr 29, 2020

@efiop , which classes should be next?

@efiop
Copy link
Contributor Author

efiop commented Apr 29, 2020

@nik123 Actually, I think that's it! 🎉 Thank you so much!

@efiop efiop closed this as completed Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Enhances DVC p3-nice-to-have It should be done this or next sprint refactoring Factoring and re-factoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: dvc/remotes class names unification nik123/dvc
2 participants
@nik123 @efiop