Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Testing UI #2858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pared opened this issue Nov 27, 2019 · 0 comments
Closed

Testing UI #2858

pared opened this issue Nov 27, 2019 · 0 comments
Labels
discussion requires active participation to reach a conclusion

Comments

@pared
Copy link
Contributor

pared commented Nov 27, 2019

It seems like we are having more and more UI issues.
Just to give a few examples:

#2839, #2691, #2602. #2854

It seems to me that there are two main problems that are the reason for this:

  1. we introduced external_repo after we had pretty well-established exception handling inside "normal" Repo (for example using relpaths inside error messages), and now we are having quite a few issues that are basically "rephrase X error because it looks strange/bad/uninformative when raised in external repo context"
  2. we do not pay too much attention to what is displayed in the log, and we do not test it

How to deal with that:
As to 1. : Eager: go through our exceptions and consider how they will look like in terminal in the context of external_repo. Lazy: just wait for issues and make changes accordingly. In both cases, tests would be useful for the future.
As to 2.: I think that we should befriend caplog, pay attention to it and check what is written to it, at least at the most important parts of tests that we write.

What do you think? @iterative/engineering

@pared pared added the discussion requires active participation to reach a conclusion label Nov 27, 2019
@ghost ghost mentioned this issue Jan 3, 2020
@efiop efiop closed this as completed May 3, 2021
@iterative iterative locked and limited conversation to collaborators May 3, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
discussion requires active participation to reach a conclusion
Projects
None yet
Development

No branches or pull requests

2 participants