You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems to me that there are two main problems that are the reason for this:
we introduced external_repo after we had pretty well-established exception handling inside "normal" Repo (for example using relpaths inside error messages), and now we are having quite a few issues that are basically "rephrase X error because it looks strange/bad/uninformative when raised in external repo context"
we do not pay too much attention to what is displayed in the log, and we do not test it
How to deal with that:
As to 1. : Eager: go through our exceptions and consider how they will look like in terminal in the context of external_repo. Lazy: just wait for issues and make changes accordingly. In both cases, tests would be useful for the future.
As to 2.: I think that we should befriend caplog, pay attention to it and check what is written to it, at least at the most important parts of tests that we write.
What do you think? @iterative/engineering
The text was updated successfully, but these errors were encountered:
It seems like we are having more and more UI issues.
Just to give a few examples:
#2839, #2691, #2602. #2854
It seems to me that there are two main problems that are the reason for this:
external_repo
after we had pretty well-established exception handling inside "normal" Repo (for example using relpaths inside error messages), and now we are having quite a few issues that are basically "rephrase X error because it looks strange/bad/uninformative when raised in external repo context"How to deal with that:
As to 1. : Eager: go through our exceptions and consider how they will look like in terminal in the context of external_repo. Lazy: just wait for issues and make changes accordingly. In both cases, tests would be useful for the future.
As to 2.: I think that we should befriend
caplog
, pay attention to it and check what is written to it, at least at the most important parts of tests that we write.What do you think? @iterative/engineering
The text was updated successfully, but these errors were encountered: