RemoteNotSpecifiedInExternalRepoError: dont pass cause of exception #2854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suor
suggested changes
Nov 26, 2019
dvc/exceptions.py
Outdated
| @@ -333,12 +333,11 @@ class CollectCacheError(DvcException): | |||
|
|
|||
|
|
|||
| class RemoteNotSpecifiedInExternalRepoError(DvcException): | |||
There was a problem hiding this comment.
Suggested change
| class RemoteNotSpecifiedInExternalRepoError(DvcException): | |
| class NoRemoteInExternalRepoError(DvcException): |
Suor
approved these changes
Nov 27, 2019
Closed
jorgeorpinel
approved these changes
Nov 27, 2019
|
Thanks @pared ! 🎉 |
|
Oops I didn't mean to approve my review haha sorry. @pared please check my questions in #2854 (review) |
|
@jorgeorpinel Oh, sorry about that. 🙁I'm sure @pared will address your comments. 🙂 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ Have you followed the guidelines in the Contributing to DVC list?
📖 Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.
❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
Related to #2711
Original solution (#2777) was passing
causeof exception resulting in obscure error message:https://asciinema.org/a/283668
For the sake of UI we agreed not to pass the cause, so that we don't end up with this long message.
https://asciinema.org/a/283669