Skip to content

import: allow downloading regular files/dirs tracked by Git? #2862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jorgeorpinel opened this issue Nov 28, 2019 · 4 comments · Fixed by #2889
Closed

import: allow downloading regular files/dirs tracked by Git? #2862

jorgeorpinel opened this issue Nov 28, 2019 · 4 comments · Fixed by #2889
Assignees
Labels
enhancement Enhances DVC feature request Requesting a new feature p1-important Important, aka current backlog of things to do

Comments

@jorgeorpinel
Copy link
Contributor

Continuation of #2515.

Per #2837 (comment), this will still be pending after finishing that ticket.

@ghost ghost added the triage Needs to be triaged label Nov 28, 2019
@jorgeorpinel jorgeorpinel changed the title import: allow downloading regular files tracked by Git import: allow downloading regular files tracked by Git? Nov 28, 2019
@jorgeorpinel jorgeorpinel added enhancement Enhances DVC question I have a question? labels Nov 28, 2019
@ghost ghost removed the triage Needs to be triaged label Nov 28, 2019
@jorgeorpinel jorgeorpinel changed the title import: allow downloading regular files tracked by Git? import: allow downloading regular files/dirs tracked by Git? Nov 28, 2019
@efiop efiop added feature request Requesting a new feature p1-important Important, aka current backlog of things to do and removed question I have a question? labels Nov 28, 2019
@Baranowski
Copy link
Contributor

Hi, I would like to work on this, as discussed with Ivan.

Below are some notes to self, please disregard.

import doesn't use get internally: #2837 (comment)

Similar functionality for get: https://github.com/iterative/dvc/pull/2837/files

From #2515 (comment):

Import doesn't support regular files IIRC. Cached directories are supported, so it would be great to support non-cached ones too as a part of this ticket

Recursive option doesn't exist for any of the commands, so it is not part of this ticket (though I'm not even sure what jorgeorpinel meant by recursive, maybe he could clarify)

From #2515 (comment)

It's really about files hosted in the Git repo vs. files referenced in the DVC-files hosted in the Git repo, right?

Docs:
https://dvc.org/doc/command-reference/get
https://dvc.org/doc/command-reference/import
https://dvc.org/doc/user-guide/dvc-file-format

@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented Dec 3, 2019

Thanks a lot Wojciech! Your internal notes are a really great summary for this issue BTW. Definitely worth having on record 🙂

import doesn't use get internally

Should it? Cc @shcheklein @MrOutis

@efiop
Copy link
Contributor

efiop commented Dec 3, 2019

Should it?

@jorgeorpinel Not necessarily, they have pretty different implementations right now and I doubt PR for this issue will have to change that. But I guess we'll soon see 🙂

@Baranowski
Copy link
Contributor

Baranowski commented Dec 4, 2019

I have a patch at #2889 but it depends on #2837, so I have marked it as Draft/WiP for now. I don't see how to better manage dependencies on GitHub but I might have missed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhances DVC feature request Requesting a new feature p1-important Important, aka current backlog of things to do
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants