Skip to content

dvc metrics diff vs dvc diff output consistency #3435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DavidGOrtega opened this issue Mar 3, 2020 · 0 comments · Fixed by #3727
Closed

dvc metrics diff vs dvc diff output consistency #3435

DavidGOrtega opened this issue Mar 3, 2020 · 0 comments · Fixed by #3727
Assignees
@efiop
Labels
bug Did we break something? p1-important Important, aka current backlog of things to do research ui user interface / interaction

Comments

@DavidGOrtega
Copy link

DavidGOrtega commented Mar 3, 2020 •
edited
Loading 

dvc diff --show-json HEAD  HEAD

ouputs nothing

dvc metrics diff --show-json HEAD  HEAD

ouputs {}

without json output :
nothing VS 'No changes.'

Please provide information about your setup
dvc 0.87.0
Python 3.6.9
ubuntu 10.04
@ghost ghost added the triage Needs to be triaged label Mar 3, 2020
@skshetry skshetry added bug Did we break something? p1-important Important, aka current backlog of things to do ui user interface / interaction labels Mar 4, 2020
@ghost ghost removed triage Needs to be triaged labels Mar 4, 2020
@efiop efiop added the research label Mar 31, 2020
@dmpetrov dmpetrov mentioned this issue Apr 28, 2020
Closed
@efiop efiop self-assigned this May 3, 2020
efiop added a commit to efiop/dvc that referenced this issue May 3, 2020
@efiop
diff: make output consistent with other diff commands
bb2e3b8 
Fixes iterative#3435
@efiop efiop mentioned this issue May 3, 2020
Merged
3 tasks
efiop added a commit that referenced this issue May 3, 2020
@efiop
diff: make output consistent with other diff commands (#3727)
505b88a 
* diff: make output consistent with other diff commands

Fixes #3435

* tests: plot: fix flaky test
@weekly-digest weekly-digest bot mentioned this issue May 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@efiop efiop

Labels
bug Did we break something? p1-important Important, aka current backlog of things to do research ui user interface / interaction
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

diff: make output consistent with other diff commands efiop/dvc
3 participants
@DavidGOrtega @efiop @skshetry