Skip to content

Relax pip dependency versions constraints for python-dateutil #3701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dchichkov opened this issue Apr 29, 2020 · 1 comment · Fixed by #3702
Closed

Relax pip dependency versions constraints for python-dateutil #3701

dchichkov opened this issue Apr 29, 2020 · 1 comment · Fixed by #3702
Labels
awaiting response we are waiting for your reply, please respond! :)

Comments

@dchichkov
Copy link
Contributor

dchichkov commented Apr 29, 2020 •
edited
Loading

Description of the problem:
ERROR: dvc 0.93.0 has requirement python-dateutil <2.8.1 ,>=2.1, but you'll have python-dateutil 2.8.1 which is incompatible.

It'd be good to remove or relax upper constraints on python-dateutil, to include 2.8.1 and 2.8.2. Is there a good reason why these are not included, or something is broken after 2.8.1 ?
@ghost ghost added the triage Needs to be triaged label Apr 29, 2020
@efiop
Copy link
Contributor

efiop commented Apr 29, 2020

Hi @dchichkov !

Mind submitting a PR to remove it? https://github.com/iterative/dvc/blob/master/setup.py#L50 It is an old sync requirement that is probably no longer needed. We'll see in the PR CI tests.

@efiop efiop added the awaiting response we are waiting for your reply, please respond! :) label Apr 29, 2020
@ghost ghost removed the triage Needs to be triaged label Apr 29, 2020
dchichkov added a commit to dchichkov/dvc that referenced this issue Apr 29, 2020
@dchichkov
Relax python-dateutil pip version constraint to include v2.8.2. itera…
0db3e68 
…tive#3701

[WIP]. Attempt to relax upper constraints on the version of python-dateutil, to include 2.8.1 and 2.8.2. 

Original constraint was:
    "python-dateutil<2.8.1,>=2.1",  # Consolidates azure-blob-storage and boto3
@dchichkov dchichkov mentioned this issue Apr 29, 2020
Merged
efiop added a commit that referenced this issue Apr 29, 2020
@dchichkov @efiop
setup: relax python-dateutil pip version constraint to include v2.8.2. …
40c6b56 
…#3701 (#3702)

* Relax python-dateutil pip version constraint to include v2.8.2.  #3701

[WIP]. Attempt to relax upper constraints on the version of python-dateutil, to include 2.8.1 and 2.8.2. 

Original constraint was:
    "python-dateutil<2.8.1,>=2.1",  # Consolidates azure-blob-storage and boto3

* Update setup.py

Co-authored-by: Ruslan Kuprieiev <[email protected]>
@weekly-digest weekly-digest bot mentioned this issue May 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
awaiting response we are waiting for your reply, please respond! :)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

setup: relax python-dateutil pip version constraint to include v2.8.2. #3701 dchichkov/dvc
2 participants
@dchichkov @efiop