Skip to content

Running tests pollutes workspace #4182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
skshetry opened this issue Jul 8, 2020 · 2 comments · Fixed by #4201
Closed

Running tests pollutes workspace #4182

skshetry opened this issue Jul 8, 2020 · 2 comments · Fixed by #4201
Assignees
@efiop
Labels
bug Did we break something? research testing Related to the tests and the testing infrastructure

Comments

@skshetry
Copy link
Collaborator

skshetry commented Jul 8, 2020

Looks like http server for tests is to blame? Refer 07da9f1

$ pytest > /dev/null
$ git status -s
? 0910e8b7-52b1-4bc8-ae0c-eef57062da8e/
?? 0c355f19-5da9-46a8-9753-1e8245220b02/
?? 3c900c05-c66c-4886-96da-cf13234079f8/
?? f1b4994c-2171-42fe-80b9-b51f5139e9f3/
@skshetry skshetry added the testing Related to the tests and the testing infrastructure label Jul 8, 2020
@skshetry skshetry changed the title Running tests polluting workspace Running tests pollutes workspace Jul 8, 2020
@efiop efiop added bug Did we break something? research p0-critical labels Jul 8, 2020
@efiop efiop self-assigned this Jul 8, 2020
@efiop
Copy link
Contributor

efiop commented Jul 10, 2020

Hm, not able to reproduce. @skshetry Could you give it another try, please?

@weekly-digest weekly-digest bot mentioned this issue Jul 12, 2020
Closed
@efiop
Copy link
Contributor

efiop commented Jul 14, 2020

For the record: discussed with @skshetry and turns out it is python 3.6. So my hack in https://github.com/iterative/dvc/blob/master/tests/utils/httpd.py#L15 doesn't work. Looking into it.

efiop added a commit to efiop/dvc that referenced this issue Jul 14, 2020
@efiop
tests: http: fix typo
274a708 
Fixes iterative#4182
@efiop efiop mentioned this issue Jul 14, 2020
Merged
3 tasks
efiop added a commit that referenced this issue Jul 14, 2020
@efiop
tests: http: fix typo (#4201)
c1b04b8 
Fixes #4182
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@efiop efiop

Labels
bug Did we break something? research testing Related to the tests and the testing infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests: http: fix typo efiop/dvc
2 participants
@efiop @skshetry