-
Notifications
You must be signed in to change notification settings - Fork 1.2k
dvc status always mark a param as changed #4184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
bug
Did we break something?
Comments
Issue is that we are skipping false values: Lines 49 to 50 in 0899b27
Should only have been: self.info[param] = value |
skshetry
added a commit
to skshetry/dvc
that referenced
this issue
Jul 9, 2020
The falsy values were being skipped when merging params values from dvc.yaml and dvc.lock, showing the values as always changed. These values were never added to `info`, but were found in `self.params` making them appear as changed. Fixes iterative#4184
3 tasks
efiop
pushed a commit
that referenced
this issue
Jul 9, 2020
The falsy values were being skipped when merging params values from dvc.yaml and dvc.lock, showing the values as always changed. These values were never added to `info`, but were found in `self.params` making them appear as changed. Fixes #4184
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Bug Report
Please provide information about your setup
Output of
dvc version
:Additional Information (if any):
dvc status
always gives me a "changed deps", when there isn't one. dvc commit / repro doesn't help.Here is the content of my
params.yaml
:Here is the related content of my
dvc.yaml
:So there are at least 2 problems here:
dvc commit
always shows the stageget_base_dv
changed, even whendvc status
didn't show that.dvc status
always shows the parameval.filter_limitup
of stageeval
changed, when actually wasn't.The text was updated successfully, but these errors were encountered: