Skip to content

dvc get --rev doesn't work if master is not a dvc repo #4188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jackspitts opened this issue Jul 10, 2020 · 3 comments · Fixed by #4190
Closed

dvc get --rev doesn't work if master is not a dvc repo #4188

jackspitts opened this issue Jul 10, 2020 · 3 comments · Fixed by #4190
Assignees

Comments

@jackspitts
Copy link

Bug Report

Please provide information about your setup

Output of dvc version:

DVC version: 1.1.7
Python version: 3.7.2
Platform: Darwin-18.7.0-x86_64-i386-64bit
Binary: False
Package: pip
Supported remotes: http, https, s3
Cache: reflink - supported, hardlink - supported, symlink - supported
Repo: dvc, git

Additional Information (if any):

Discord link with all info

https://discordapp.com/channels/485586884165107732/485596304961962003/731227119954427904

@ghost ghost added the triage Needs to be triaged label Jul 10, 2020
@efiop efiop self-assigned this Jul 10, 2020
@ghost ghost removed the triage Needs to be triaged label Jul 10, 2020
@efiop
Copy link
Contributor

efiop commented Jul 10, 2020

For the record: the issue is that in external repo we operate on virtual trees(we don't checkout to the branch), but we still read config through regular open() calls, which is causing this issue. Need to make our config use repo's self.tree to read/write configs.

@efiop efiop mentioned this issue Jul 10, 2020
3 tasks
efiop added a commit to efiop/dvc that referenced this issue Jul 12, 2020
efiop added a commit that referenced this issue Jul 12, 2020
@efiop
Copy link
Contributor

efiop commented Jul 12, 2020

@jackspitts 1.1.9 is out with the fix. Please upgrade and give it a try 🙂 Thanks for the feedback!

@jackspitts
Copy link
Author

@efiop Upgraded and dvc get --rev works like a charm. Thanks for the quick turn around!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants