Skip to content

housekeeping tasks #4468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
12 of 19 tasks
skshetry opened this issue Aug 25, 2020 · 7 comments
Closed
12 of 19 tasks

housekeeping tasks #4468

skshetry opened this issue Aug 25, 2020 · 7 comments

Comments

@skshetry
Copy link
Collaborator

skshetry commented Aug 25, 2020

Some of the things in addition to "move to GHA" and changelog:

CI

Tests

Packaging

These were the tasks I have been keeping tracks of on a separate list, thought I'd just dump. Not everything needs to fixed though. I could take them when I am free as well.

@skshetry skshetry self-assigned this Aug 25, 2020
@efiop
Copy link
Contributor

efiop commented Aug 25, 2020

update restyler? How to keep that in-sync? Should we host our own docker images that are kept fresh?

Could consider disabling it. Seems like our linter job is doing the thing and we don't actually use restyler's PRs that often, as people tend to fix their patches when they see that linter complains.

@shcheklein
Copy link
Member

Should we make some of them hacktoberfest tickets for the upcoming event?

@skshetry
Copy link
Collaborator Author

skshetry commented Oct 2, 2020

@shcheklein, sure, we can split this ticket.

@DiPaolo
Copy link
Contributor

DiPaolo commented Dec 25, 2020

I've just spotted the missed year and copyright owner in LICENSE file:

dvc/LICENSE

Line 189 in 11382cc

Copyright {yyyy} {name of copyright owner}

Should it be added as a housekeeping item as well?

@skshetry
Copy link
Collaborator Author

@DiPaolo, it is a boilerplate to copy in your work (or, source files) that you want to specifically apply Apache License (and, replace that syntax with information).

Here's what Apache License says:

To apply the Apache License to specific files in your work, attach the following boilerplate declaration, with the fields enclosed by brackets "[]" replaced with your own identifying information. (Don't include the brackets!)

Which is close to what's in the LICENSE:

dvc/LICENSE

Lines 180 to 184 in 11382cc

To apply the Apache License to your work, attach the following
boilerplate notice, with the fields enclosed by brackets "{}"
replaced with your own identifying information. (Don't include
the brackets!) The text should be enclosed in the appropriate
comment syntax for the file format. We also recommend that a

To emphasize the last line:

The text should be enclosed in the appropriate comment syntax for the file format.

@isidentical
Copy link
Contributor

isidentical commented Feb 2, 2021

Cache pre-commit's caches on CI.

I guess we can simply use the official pre-commit action, pre-commit/action. It automatically handles the caching

@skshetry
Copy link
Collaborator Author

Closing as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants