Skip to content

Investigate flaky tests_open_granular[azure] #4792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pared opened this issue Oct 26, 2020 · 4 comments
Closed

Investigate flaky tests_open_granular[azure] #4792

pared opened this issue Oct 26, 2020 · 4 comments
Assignees
Labels
bug Did we break something? testing Related to the tests and the testing infrastructure

Comments

@pared
Copy link
Contributor

pared commented Oct 26, 2020

tests/func/test_api.py::test_open_granular[azure] seems to be failing sometimes (example). We need to fix it.

@pared pared added testing Related to the tests and the testing infrastructure bug Did we break something? labels Nov 2, 2020
@efiop
Copy link
Contributor

efiop commented Nov 9, 2020

Looks like it is simply racing a bit. The container is not ready when this is called. Just need to add a flaky decorator.

@skshetry
Copy link
Collaborator

@efiop, better to wait for and timeout than adding flaky, as rerunning it still has chances of the container not being ready.

@ju0gri
Copy link
Contributor

ju0gri commented Nov 10, 2020

I'll be looking into this issue.

@efiop
Copy link
Contributor

efiop commented Nov 10, 2020

@skshetry Great point! Ideally we need some retrying logic in our trees, but that is a much bigger task. Just slapping a flaky decorator should do the trick for now.

ju0gri added a commit to ju0gri/dvc that referenced this issue Nov 11, 2020
Related: iterative#4792

Signed-off-by: Ioana Grigoropol <[email protected]>
efiop pushed a commit that referenced this issue Nov 11, 2020
Related: #4792

Signed-off-by: Ioana Grigoropol <[email protected]>
@efiop efiop closed this as completed Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Did we break something? testing Related to the tests and the testing infrastructure
Projects
None yet
Development

No branches or pull requests

4 participants