Skip to content

stage: check if local path contains symlink and, if so, treat added files as relpath #1662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2019

Conversation

pared
Copy link
Contributor

@pared pared commented Feb 26, 2019

Fixes #1648
To allow adding data from path that is symlinked into our repository, check whether provided path is link. If so, create stage file in project root.

@pared pared force-pushed the 1648 branch 2 times, most recently from 3abdecf to 350e7cc Compare February 27, 2019 09:01
Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! A few more comments down below.

@pared pared force-pushed the 1648 branch 2 times, most recently from 97589c4 to 151a055 Compare February 27, 2019 16:38
Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Thank you!

@efiop efiop merged commit 92d7445 into iterative:master Feb 28, 2019
@pared pared deleted the 1648 branch April 3, 2019 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants