repo: remind to git add only when using git #1693
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
pared
reviewed
Mar 7, 2019
| @@ -93,7 +93,9 @@ def find_dvc_dir(root=None): | |||
| return os.path.join(root_dir, Repo.DVC_DIR) | |||
|
|
|||
| def remind_to_git_add(self): | |||
| if not self.files_to_git_add: | |||
| is_git_repo = type(self.scm).__name__ == "Git" | |||
There was a problem hiding this comment.
Should we check it by name? Maybe something like:
type(self.scm) is dvc.scm.Git?
efiop
reviewed
Mar 7, 2019
| @@ -93,7 +93,9 @@ def find_dvc_dir(root=None): | |||
| return os.path.join(root_dir, Repo.DVC_DIR) | |||
|
|
|||
| def remind_to_git_add(self): | |||
There was a problem hiding this comment.
Also, @pared introduced remind_to_track method in https://github.com/iterative/dvc/pull/1673/files , so if scm is not git it simply won't do anything, so this change seems to be not needed anymore.
|
Closing in favor of #1673 |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1685