-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Remove multi-threaded prefix before progress bar(#2686) #2703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
How does it work? Do we have blank line now instead? |
@Suor @kurianbenoy just updated this PR to "fix" (unfix) the issue. May have to revert at some point in the future if we start doing different things with nested multi-threaded bars but for now should be fine. |
Just a reminder - adding other messages for commands should be separate issue(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So how does it work now? Will progress bars be cleared properly without this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok killed off TqdmThreadPoolExecutor
... ready for merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you guys! 🙏
Fix #2686
Also change the import to follow PEP8 import rules
Have you followed the guidelines in our
Contributing document?
Does your PR affect documented changes or does it add new functionality
that should be documented? If yes, have you created a PR for
dvc.org documenting it or at
least opened an issue for it? If so, please add a link to it.