Skip to content

Remove multi-threaded prefix before progress bar(#2686) #2703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 2, 2019
Merged

Remove multi-threaded prefix before progress bar(#2686) #2703

merged 4 commits into from
Nov 2, 2019

Conversation

kurianbenoy
Copy link
Contributor

@kurianbenoy kurianbenoy commented Oct 31, 2019

Fix #2686

Also change the import to follow PEP8 import rules

  • Have you followed the guidelines in our
    Contributing document?

  • Does your PR affect documented changes or does it add new functionality
    that should be documented? If yes, have you created a PR for
    dvc.org documenting it or at
    least opened an issue for it? If so, please add a link to it.


@shcheklein shcheklein requested a review from casperdcl October 31, 2019 17:02
@Suor
Copy link
Contributor

Suor commented Nov 1, 2019

How does it work? Do we have blank line now instead?

@casperdcl
Copy link
Contributor

@Suor @kurianbenoy just updated this PR to "fix" (unfix) the issue. May have to revert at some point in the future if we start doing different things with nested multi-threaded bars but for now should be fine.

@casperdcl
Copy link
Contributor

Just a reminder - adding other messages for commands should be separate issue(s).

Copy link
Contributor

@Suor Suor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So how does it work now? Will progress bars be cleared properly without this?

@casperdcl casperdcl self-requested a review November 2, 2019 15:26
Copy link
Contributor

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok killed off TqdmThreadPoolExecutor... ready for merge.

Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you guys! 🙏

@efiop efiop merged commit 372e107 into iterative:master Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui: remove multi threaded prefix before each progress bar
4 participants