Skip to content

update py3.7 => py3.8 #2912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

update py3.7 => py3.8 #2912

wants to merge 1 commit into from

Conversation

casperdcl
Copy link
Contributor

No description provided.

@casperdcl casperdcl self-assigned this Dec 6, 2019
@@ -30,7 +30,7 @@ jobs:
stage: check
os: linux
language: python
python: 3.7
python: 3.8
Copy link
Contributor

@efiop efiop Dec 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't replace it, but rather be a new addition. Same with stuff down below.

Copy link
Contributor

@efiop efiop Dec 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or was it just a test?

In any case, we've had some issues with conda packages on 3.8, so probably not all dependencies are ready yet. I would wait until all our deps support 3.8.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a draft, py3.8 has been officially released so should be mergeable soon

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the main blocker is cython even though it installs in a local py38 env... have you made a start on debugging these issues in another PR @efiop?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@casperdcl Not really, 38 is not that urgent :) I would just wait a bit until everything settles in other projects. E.g. https://pypi.org/project/pyarrow/#files still doesn't have 3.8 wheels. I imagine 3.8 will settle down in Jan or something.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Def wouldn't spend time on it for now.

@casperdcl casperdcl removed their assignment Dec 6, 2019
@casperdcl casperdcl added enhancement Enhances DVC p3-nice-to-have It should be done this or next sprint research testing Related to the tests and the testing infrastructure labels Dec 6, 2019
@efiop efiop mentioned this pull request Jan 2, 2020
@efiop
Copy link
Contributor

efiop commented Jan 20, 2020

Closing for now. We'll wait a bit and then will add 3.8 in addition to 3.7, not instead.

@efiop efiop closed this Jan 20, 2020
@casperdcl casperdcl mentioned this pull request Mar 12, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhances DVC p3-nice-to-have It should be done this or next sprint research testing Related to the tests and the testing infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants