repo: Support streaming and pulling files on RepoTree/DvcTree.open()
#3810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
efiop
reviewed
May 18, 2020
efiop
approved these changes
May 18, 2020
efiop
reviewed
May 18, 2020
| if out.is_dir_checksum and (self.fetch or self.stream): | ||
| # will pull dir cache if needed | ||
| with self.repo.state: | ||
| cache = out.collect_used_dir_cache() |
There was a problem hiding this comment.
Might be slow to collect. You only need out.dir_cache, so maybe it is worth creating extracting some method to fetch .dir for it into an out method. But I'm ok with keeping it as is for now.
|
Ok, looks great. We are on the right track. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.
❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
RepoTreenow supports allBaseTreemethodsRepoTree/DvcTree.open().DvcTreewas initialized withfetch=Trueorstream=True, the out will be fetched or streamed, otherwise an error will be raisedRepo.open_by_relpath()now usesRepoTree.open()RepoTree/DvcTree.walk()now support walking dir contents for dir outsfetch=Trueorstream=True, tree will pull dir cache for dir outs onwalkwhen neededRelated to #3811.