utils: support use of (GitTree) tree file objects in utils #3819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmrowla
force-pushed
the
git-tree-extensions
branch
from
25e4406 to
e8ec3da
Compare
pmrowla
commented
May 19, 2020
| @@ -202,6 +198,12 @@ def copyfile(src, dest, no_progress_bar=False, name=None): | |||
| fdest_wrapped.write(buf) | |||
|
|
|||
|
|
|||
| def copy_fobj_to_file(fsrc, dest): | |||
There was a problem hiding this comment.
I think we will probably want progress bar support for this once we are saving files from git tree to local cache, but I think it may make more sense to have the pbar instance in the higher level save() method.
So at that point we can add a pbar update callback parameter to this method (and do buffered read/write instead of using shutil.copyfileobj as needed).
pared
approved these changes
May 19, 2020
efiop
approved these changes
May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.
❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
Miscellaneous improvements to GitTree and utils that will be needed for cache/repo tree changes.
Related to #3811.