Skip to content

tests: launch oss/azure containers from fixtures #4178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2020
Merged

tests: launch oss/azure containers from fixtures #4178

merged 2 commits into from
Jul 8, 2020

Conversation

efiop
Copy link
Contributor

@efiop efiop commented Jul 7, 2020

  • ❗ I have followed the Contributing to DVC checklist.

  • πŸ“– If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.

  • ❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

@efiop efiop changed the title tests: launch oss/azure containers from fixtures [WIP] tests: launch oss/azure containers from fixtures Jul 7, 2020
@efiop efiop force-pushed the fix-4054 branch 5 times, most recently from e4cc686 to 10ce3eb Compare July 8, 2020 01:55
ports:
- "10000"
oss:
image: rkuprieiev/oss-emulator
Copy link
Contributor Author

@efiop efiop Jul 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using my personal repo while waiting to be granted access to iterativeai dockerhub org πŸ™‚

@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #4178 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4178      +/-   ##
==========================================
- Coverage   92.70%   92.61%   -0.09%     
==========================================
  Files         162      162              
  Lines       11313    11313              
==========================================
- Hits        10488    10478      -10     
- Misses        825      835      +10     
Impacted Files Coverage Ξ”
dvc/remote/gdrive.py 81.85% <0.00%> (-3.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 253a0ea...ef8d056. Read the comment docs.

@efiop efiop changed the title [WIP] tests: launch oss/azure containers from fixtures tests: launch oss/azure containers from fixtures Jul 8, 2020
@efiop efiop merged commit 0899b27 into master Jul 8, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-4054 branch July 8, 2020 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant