gdrive: add workaround for downloading empty files #4287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` pylint...................................................................Failed - hook id: pylint - exit code: 2 Registered custom plugin. Some checks will be disabled for tests. ************* Module dvc.command.experiments dvc/command/experiments.py:14:4: E0401: Unable to import 'flatten_json' (import-error) dvc/command/experiments.py:39:4: E0401: Unable to import 'flatten_json' (import-error) ----------------------------------- Your code has been rated at 9.99/10 Registered custom plugin. Some checks will be disabled for tests. ************* Module dvc.utils.diff dvc/utils/diff.py:38:8: E0401: Unable to import 'flatten_json' (import-error) ************* Module dvc.command.metrics dvc/command/metrics.py:17:4: E0401: Unable to import 'flatten_json' (import-error) ----------------------------------- ```
Codecov Report
@@ Coverage Diff @@
## master #4287 +/- ##
=======================================
Coverage 91.72% 91.72%
=======================================
Files 173 173
Lines 11745 11762 +17
=======================================
+ Hits 10773 10789 +16
- Misses 972 973 +1
Continue to review full report at Codecov.
|
efiop
changed the title
|
User confirmed this working, so in the interest of time I'll merge and release this workaround and will properly handle upload and download in iterative/PyDrive2#48 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better to solve it on PyDrive's side:
#4286
Fixes #4286
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏