Skip to content

daemon: use Popen on Mac #4296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2020
Merged

daemon: use Popen on Mac #4296

merged 1 commit into from
Jul 28, 2020

Conversation

efiop
Copy link
Contributor

@efiop efiop commented Jul 28, 2020

Turns out macs are not happy with double-forks without exec.

Fixes #4294

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

Turns out macs are not happy with double-forks without exec.

Fixes iterative#4294
@efiop efiop requested a review from pmrowla July 28, 2020 12:50
@efiop
Copy link
Contributor Author

efiop commented Jul 28, 2020

@pmrowla Could you give this one a try, please? Just to make sure.

@dtrifiro
Copy link
Contributor

dtrifiro commented Jul 28, 2020

@pmrowla Could you give this one a try, please? Just to make sure.

The crashes are gone (tested on Darwin mac 18.7.0 Darwin Kernel Version 18.7.0: Mon Apr 27 20:09:39 PDT 2020; root:xnu-4903.278.35~1/RELEASE_X86_64 x86_64), python 3.7.8

@efiop
Copy link
Contributor Author

efiop commented Jul 28, 2020

@dtrifiro Thank you so much! Releasing new version ASAP.

@efiop efiop merged commit 0b111d2 into iterative:master Jul 28, 2020
@pmrowla
Copy link
Contributor

pmrowla commented Jul 28, 2020

confirming that it works for me as well

Python version: 3.8.5
Platform: macOS-10.15.6-x86_64-i386-64bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macOS: analytics daemon crashes due to fork related error
3 participants