Skip to content

metrics/plots: initial support non-dvc repos #4627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2020
Merged

Conversation

efiop
Copy link
Contributor

@efiop efiop commented Sep 28, 2020

Initial hacky support, that still tries to create .dvc directory as a side-effect. That side effect will be addressed in the upcoming
PR. This feature in general makes us really rethink what a dvc repo is and whether having .dvc is really required.

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

scm=None,
rev=None,
subrepos=False,
uninitialized=False,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might consider getting rid of this in the future (for now needed for backward compatibility). Currently dvc init doesn't do much useful things and all .dvc contents could be (and should probably) be created dynamically.

Even things like dvc add could potentially just work in a pure git repo. Just something to think about...

@efiop efiop merged commit 1ea8cc9 into iterative:master Sep 28, 2020
@efiop efiop added feature request Requesting a new feature feature is a feature and removed feature request Requesting a new feature labels Sep 30, 2020
@jorgeorpinel
Copy link
Contributor

This feature in general makes us really rethink what a dvc repo is and whether having .dvc is really required.

Interesting (and I've noticed this mentioned elsewhere) can you elaborate a little? Or is there a discussion somewhere I can keep an eye and participate on this idea? Thanks

@efiop
Copy link
Contributor Author

efiop commented Sep 30, 2020

@jorgeorpinel Not yet, only verbal discussions at this point. We'll probably create something in the future.

@pared pared mentioned this pull request Oct 2, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature is a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants