gha: add gs creds #4791
gha: add gs creds #4791
Conversation
Related to #4418
| - name: setup gs creds | ||
| shell: bash | ||
| run: | | ||
| mkdir -p scripts/ci |
There was a problem hiding this comment.
Using what is already used in the code for now. Don't want to mess with the tests themselves in this PR, just making this run the same way it did on travis.
|
Failing test seems unrelated: it is |
| try: | ||
| check_output( | ||
| [ | ||
| "gcloud", | ||
| "auth", | ||
| "activate-service-account", | ||
| "--key-file", | ||
| TEST_GCP_CREDS_FILE, | ||
| ] | ||
| ) | ||
| except (CalledProcessError, OSError): | ||
| return False |
There was a problem hiding this comment.
Had to get rid of this to make gs tests less flaky. This is an old leftover that is no longer needed after test_data_cloud CLI refactoring done a few months back, where we started properly using config.
|
gs mac/linux tests are operational, waiting for windows tests to complete... EDIT0: windows works too. EDIT1: the resources are tight on windows, running into git exe failures 🙁 We'll need to start migrating to gitpython alternatives for some functionality very soon. |
Related to #4418
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏