dvc: add size/nfiles for deps/outs #4836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
changed the title
efiop
changed the title
efiop
commented
Nov 4, 2020
Comment on lines
281
to
284
| f"- {hash_name}: {hash_value}\n" | ||
| " size: 11\n" | ||
| " nfiles: 2\n" | ||
| " path: remote://workspace/dir\n" |
There was a problem hiding this comment.
This should really be:
- path: ...
md5: ...
size: ...
nfiles: ...
added a checkbox to #4841 , but we could do this right away, as it will only affect the newly written files, which is a bit annoying but not that bad.
efiop
commented
Nov 4, 2020
Comment on lines
+137
to
+143
| def _dumpd(item): | ||
| ret = [ | ||
| (item.PARAM_PATH, item.def_path), | ||
| *item.hash_info.to_dict().items(), | ||
| ] | ||
|
|
||
| return OrderedDict(ret) |
There was a problem hiding this comment.
This should eventually turn into a special Dumper for outputs or into Output.dumpd_lock(or smth like that). We've discussed it before.
efiop
force-pushed
the
fix-3256
branch
6 times, most recently
from
eb4a9b1 to
8bd3c1f
Compare
efiop
changed the title
efiop
changed the title
efiop
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3256
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
iterative/dvc.org#1907
Thank you for the contribution - we'll try to review it as soon as possible. 🙏