Cleanup debug log messages when loading stages #5125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Simplified callback stage debug message 2. Reduced no lock entry message to trace If lockfile does not have some entry, it will simply complain that lockfile is not uptodate once. If there is no lockfile or empty lockfile, it will complain that lockfile not found. 3. Annoying parametrization related wdir-interpolated debug message removed.
efiop
reviewed
Dec 17, 2020
| @@ -256,12 +256,7 @@ def changed_deps(self): | |||
| return False | |||
|
|
|||
| if self.is_callback: | |||
There was a problem hiding this comment.
The whole callback logic can be deleted now, it has been obsoleted since 1.0
There was a problem hiding this comment.
How so? The callback is still present on the outputs during run/repro, so let's remove it later at the same time.
There was a problem hiding this comment.
We have a checkbox #4841 . Sure, can do that separately, just saying.
skshetry
commented
Dec 17, 2020
skshetry
commented
Dec 17, 2020
efiop
approved these changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If lock file does not have some entry, it will simply complain
that lock file is not up to date once.
If there is no lock file or empty lock file, it will complain that lock file not found.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏