run-cache: skip unhashable stages #5185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
commented
Dec 31, 2020
| cache = StageCache(repo) | ||
| stage = Stage(repo, always_changed=True) | ||
| cache = StageCache(dvc) | ||
| stage = create_stage(Stage, path="stage.dvc", repo=dvc, **kwargs) |
There was a problem hiding this comment.
Too lazy to mock this out perfectly (as in many other tests). We need some nice factory for stages to use in tests 🙁
efiop
commented
Dec 31, 2020
| @@ -167,7 +172,7 @@ def save(self, stage): | |||
| self.tree.move(PathInfo(tmp), path) | |||
|
|
|||
| def restore(self, stage, run_cache=True, pull=False): | |||
| if stage.is_callback or stage.always_changed: | |||
| if not _can_hash(stage): | |||
There was a problem hiding this comment.
Better approach here would be to try to checkout/pull anything that is up-to-date(e.g. dvc added files and always_changed stages, but that needs to be done on a higher level as well as here. Will be resolved in #4742
efiop
changed the title
efiop
changed the title
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5182
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏