Skip to content

add support for 3.12 #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 8, 2023
Merged

add support for 3.12 #28

merged 3 commits into from
Dec 8, 2023

Conversation

skshetry
Copy link
Collaborator

@skshetry skshetry commented Dec 8, 2023

DeprecationWarning is now emitted when named placeholders are used together with parameters supplied as a sequence instead of as a dict. Starting from Python 3.14, using named placeholders with parameters supplied as a sequence will raise a ProgrammingError.

See python/cpython#101693, and discussion on https://discuss.python.org/t/sqlite3-consider-deprecating-combining-named-placeholders-with-sequence-of-params/22450.

@skshetry skshetry requested a review from efiop December 8, 2023 16:00
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d046e28) 81.52% compared to head (d9f56fc) 81.52%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #28   +/-   ##
=======================================
  Coverage   81.52%   81.52%           
=======================================
  Files          11       11           
  Lines         655      655           
  Branches      111      111           
=======================================
  Hits          534      534           
  Misses        109      109           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@efiop efiop merged commit d03f3ce into main Dec 8, 2023
@skshetry skshetry deleted the 3.12-support branch December 8, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants