Feature ideas (starting to implement, but looking for advice)

[JohnnyFun]

I'm working on a few things and would like to know if you think they're good ideas.

1. Improve go-to-def: currently typescript seems to ignore your extra extensions (.html, .svelte). I set the scriptKind, which made it include svelte/html files:
   

And then updated the fallback resolution that had only been resolving as a relative path:

That mostly seemed to make non-relative references work, but some svelte files' symbols don't seem to get loaded, so not sure what's up there. Maybe you have some insight?

2. Auto-import as you type component name like:
   

I started implementing this in HTMLPlugin.ts.getCompletions, but let me know if you prefer it elsewhere. Perhaps SveltePlugin would be more appropriate?

[JohnnyFun]

I might actually change my approach for go-to-def to just implement it in the svelteplugin. Thinking I could probably just do a dumbed-down but useful module resolution that takes nearest tsconfig/jsconfig paths and baseUrl into account. That way, svelte-specific logic is kept more separate from ts logic.

That strategy might also make it more intuitive to implement go-to-def from a tag in the template too, so user can do go-to-def from something like "<MyComponent" too, not just from the import statement in the script block. Would just need to find the import statement in the script block if it exists and use that to resolve it. If it doesn't exist, that could be another point at which to give a completion to auto-import.

Feel free to let me know if you have better ideas. I'll post my code regardless when done (might be a while), even if it's hacky since it at least might be a good starting point.

[JohnnyFun]

I got go-to-def working well from either import statements or template.

It also looks for tsconfig/jsconfig and uses that to determine other base paths to look in case the import path is not relative.

The code is just POC currently, but once I get the auto-import completion stuff in place, I'll write some tests, refactor, and let you know.

I'll put progress here: https://github.com/JohnnyFun/svelte-language-server/tree/feat-better-go-to-def

[JohnnyFun]

Here it is so far (I'll stop blowing up your inbox lol, just pumped). Thanks for such a great starting point to really improve our svelte IDE experience.

The selection range is wonky, but I'll resolve that...

[JohnnyFun]

For anyone who'd like to play with these, here's how I have my fellow devs running it locally for now (we're win10, so modify accordingly for mac/linux):

• open in file explorer: C:\Users[user].vscode\extensions\jamesbirtles.svelte-vscode-0.9.3\node_modules
• rename "svelte-language-server" to "svelte-language-server_ORIGINAL"
• clone https://github.com/JohnnyFun/svelte-language-server in the same location
  • this will be the new "svelte-language-server" folder and you'll be able to pull from there if I add anything later
• git checkout feat-better-go-to-def
• npm i && npm run build
  • build will "fail" but ts still outputs js, so worry not
• re-open vscode and you should have the goods!
• (Optional) you can set up a tsconfig.json or jsconfig.json to make the auto-imports use that instead of relative paths. For example here's mine (app code is in Client/js, tests are in cypress, so I can import relative to those):

{
	"compilerOptions": {
		"allowJs": true, // basically makes it a jsconfig.json file
		"baseUrl": "./",
		"target": "esnext",
		"moduleResolution": "node",
		"traceResolution": true,
		"paths": {
			"*": [
				"./Client/js/*",
				"./cypress/*"
			]
		}
	},
	"include": [
		"./Client/js",
		"./cypress"
	],
	"exclude": [
		"./node_modules"
	]
}

If you run into issues, couple things you can do:

• restart the svelte-language-server and try again: ctrl+shift+p > Svelte: Restart Language Server
• revert to original:
  • rename "svelte-language-server" to "svelte-language-server_NO_BUENO"
  • rename "svelte-language-server_ORIGINAL" to "svelte-language-server"
  • restart the svelte-language-server and try again: ctrl+shift+p > Svelte: Restart Language Server

[swyxio]

havent had a chance to try it yet but just leaving a comment to say THIS LOOKS GREAT and keep going!!

[JohnnyFun]

Thanks, @sw-yx! It's been helping us out a lot so far, even with a fairly naive implementation at this point. I'll keep chipping away over time. Currently just implemented using misc regex, but hoping to add to the abstract-syntax-tree stuff that looks to be available. I hope that vscode also adds better support for js in <script> tags soon.

[JohnnyFun]

I want to see if there's maybe a way to get typescript to treat the contents of the <script> block as though it's a js file at the same location as the html, so we get intellisense as though we're in a js file within the script block with autocomplete, refactor-extract-method, etc. But we'll see, not sure if that'd be possible at this point.

[swyxio]

It's been helping us out a lot

who's "us"?

[JohnnyFun]

I'm contracting for a company "ClinicianNexus". I just switched their codebase from Ractive to Svelte.

[PatrickG]

It's nice that someone is moving the project forward.
Unfortunately your fork does not work for me when organizing my components in folders, .i.e: src/components/Button/Button.svelte with an index.js (export { default, default as Button } from './Button.svelte).

Also, do you think you could fix that ctrl+click works only on the first <script>-block, that's annoying when having a <script context="module">-block (even when ctrl+click only works in non-module-blocks would be nice)

[JohnnyFun]

Good call, @PatrickG. Yeah, at some point I want to refactor it to use abstract syntax tree instead of regex. Might not be for a while, but definitely on my radar. I'll update you when I do though!

[JakubKoralewski]

@UnwrittenFun I can see you have stopped actively maintaining this project, and that's fine. Maintaining open-source projects can be overwhelming with many people depending on you.

That's why I propose you added @JohnnyFun as a collaborator. Apart from sharing a surname, he seems to know his stuff, and it would be nice since people wanting to contribute would find this repository and things would keep growing, as they seem to be stalled right now.

Just an idea.

[jamesbirtles]

@Rich-Harris expressed interest in moving it to the sveltejs org which would be my preference

[VaelVictus]

What does that mean?

[JohnnyFun]

Rich Harris talks a bit about what this could mean in this recent video. Sounds like they're implementing typescript support and will probably use much of this code as a starting point. He mentions that we might see more traction on it in the next couple months.

https://www.youtube.com/watch?v=luM5uobewhA&amp=&feature=youtu.be&amp=&t=41