Skip to content

Conversation

@fredboyle
Copy link

Addresses issue #149.

Fred Boyle added 2 commits July 31, 2023 15:08
Copy link
Owner

@jamesmartin jamesmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR. ✨

I had a question about the choice of strip vs. strip!. Thanks for updating the tests. 👍

Signed-off-by: Fred Boyle <[email protected]>
Copy link
Owner

@jamesmartin jamesmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@jamesmartin jamesmartin merged commit 1a1e2e0 into jamesmartin:main Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants