Updated to work with Dart 1.24 #1
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated crypto dependency
Updated dependency on the crypto package to '>=0.9.2 <3.0.0' to allow a newer version of crypto to be used that is compatible with Dart 1.24.
This was necessary, since the previous crypto dependency was '>=0.9.0 <0.10.0' which used crypto 0.9.2+1 -- and that version of crypto is incompatible with Dart 1.24 and newer. The underlying problem is because crypto 0.9.2+1 only works with convert 1.1.1 and earlier, and convert 1.1.1 and earlier needed the ChunkedConverter class. But Dart 1.24 has removed the ChunkedConverter class. Unfortunately, this was a breaking change even though the major version number of Dart was not changed to indicate that.
The result is sqljocky 0.14.1 is incompatible with Dart 1.24 and newer. The error message seen when trying to run "pub get" is:
The newer versions of crypto uses newer versions of convert which are compatible with Dart 1.24, because they do not need the ChunkedConverter class.
Some code changes were necessary in auth_handler.dart to work with the newer versions of _crypto. Previously it was using a deprecated class (SHA1) that has been removed since crypto 1.0.0.
Cleaned up warnings
Cleaned up the code to remove some warnings (e.g. unused variables).
Cleaned up tests
Also, changed the print statements in the tests to go to logging (which is disabled by default). This way they don't clutter up the output so the
pub run test
command can parse the output.Only one problem: integration test "issue 43" does not pass. But it didn't seem to pass before these changes. So was it previously broken?