Skip to content

Fix failed auth if password contains a colon #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix failed auth if password contains a colon #67

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ffe2dd
fix failed auth if password contains a colon
corpsmoderne Mar 1, 2017
dfac2ac
fix tests
corpsmoderne Mar 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/passport-http/strategies/basic.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,11 @@ BasicStrategy.prototype.authenticate = function(req) {
var parts = authorization.split(' ')
if (parts.length < 2) { return this.fail(400); }

var scheme = parts[0]
, credentials = new Buffer(parts[1], 'base64').toString().split(':');

var scheme = parts[0], credstr = new Buffer(parts[1], 'base64').toString();
if (credstr.indexOf(":") === -1) { return this.fail(400); }
var credentials = [ credstr.substr(0, credstr.indexOf(":")),
credstr.substr(credstr.indexOf(":")+1) ];
if (!/Basic/i.test(scheme)) { return this.fail(this._challenge()); }
if (credentials.length < 2) { return this.fail(400); }

var userid = credentials[0];
var password = credentials[1];
Expand Down