Skip to content

Conversation

Nexarian
Copy link
Contributor

@Nexarian Nexarian commented Sep 23, 2025

Merge #216 first

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 27.52%. Comparing base (5e50e0f) to head (23882ed).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #218   +/-   ##
=======================================
  Coverage   27.52%   27.52%           
=======================================
  Files          35       35           
  Lines        5413     5413           
  Branches      752      752           
=======================================
  Hits         1490     1490           
  Misses       3846     3846           
  Partials       77       77           
Flag Coverage Δ
py3.10 27.52% <ø> (ø)
py3.11 27.52% <ø> (ø)
py3.12 27.52% <ø> (ø)
py3.13 27.52% <ø> (?)
py3.9 27.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Nexarian Nexarian force-pushed the continue-proxy-unit-testing-tranche-2 branch 4 times, most recently from 7993dae to 7af31ae Compare September 23, 2025 17:31
@Nexarian
Copy link
Contributor Author

Still not ready, the "Simulator up" check is wrong. Need to fix somehow.

@Nexarian Nexarian force-pushed the continue-proxy-unit-testing-tranche-2 branch 3 times, most recently from 8cf534d to 43b977a Compare September 25, 2025 01:37
@Nexarian
Copy link
Contributor Author

Ok this works now, but I'll split it up into more sensical pieces. I fell into a rabbit hole on the simulator and making sure that even forks use the proper image from the repo root.

- Also update simulator
@Nexarian Nexarian force-pushed the continue-proxy-unit-testing-tranche-2 branch from 43b977a to 23882ed Compare September 28, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants