Skip to content

update enums article #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 25, 2024
Merged

update enums article #116

merged 4 commits into from
Sep 25, 2024

Conversation

danthe1st
Copy link
Contributor

This PR contains minor updates to the enums article I originally contributed in #45.

I made changes to the writing (e.g. "exhaustiveness checking" instead of "exhaustiveness") and
I made the following changes:

  • use the plural of enum constants in a comment about listing them
  • use the name "exhaustiveness checking" (should that be Title Case?) instead of just the concept of exhaustiveness as well as add a link to the patternmatching article (The article isn't available in this repository so I didn't use an id: link)
  • move the enum constants of the enum with more than the enum declaration in the class body to two lines. This makes it easier to see the ; after the enum declaration.
  • add a few spaces in code as most people prefer that I think
  • slightly reword the conclusion

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jun 28, 2024
Copy link
Collaborator

@ammbra ammbra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Dan 👋 ,

Thank you for contributing back with these changes. Can you please take a look at my suggestions (there is no need to add capital letters in the beginning of switch expressions, sealed classes etc).

@danthe1st
Copy link
Contributor Author

Thank you for your review. I addressed the feedback.

@danthe1st
Copy link
Contributor Author

Is there anything else I should change?

@ammbra
Copy link
Collaborator

ammbra commented Jul 15, 2024

All good.

Copy link
Collaborator

@ammbra ammbra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ammbra ammbra merged commit f0fadfe into java:main Sep 25, 2024
1 check passed
@danthe1st danthe1st deleted the enum-update branch September 26, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants