-
Notifications
You must be signed in to change notification settings - Fork 25
update enums article #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update enums article #116
Conversation
app/pages/learn/01_tutorial/03_getting-to-know-the-language/04_classes_objects/01_enums.md
Outdated
Show resolved
Hide resolved
app/pages/learn/01_tutorial/03_getting-to-know-the-language/04_classes_objects/01_enums.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Dan 👋 ,
Thank you for contributing back with these changes. Can you please take a look at my suggestions (there is no need to add capital letters in the beginning of switch expressions, sealed classes etc).
Thank you for your review. I addressed the feedback. |
app/pages/learn/01_tutorial/03_getting-to-know-the-language/04_classes_objects/01_enums.md
Outdated
Show resolved
Hide resolved
Is there anything else I should change? |
All good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
This PR contains minor updates to the enums article I originally contributed in #45.
I made changes to the writing (e.g. "exhaustiveness checking" instead of "exhaustiveness") and
I made the following changes:
id:
link);
after the enum declaration.