Skip to content

An Introduction to JavaScript, rejected due to duplicate work #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

danipoma
Copy link
Contributor

Hello.

Creating a PR for first translated page into Czech.
If I am doing something wrong, please say so as this is my first time using git.

Best Regards.

@javascript-translate-bot javascript-translate-bot added the review needed Review needed, please approve or request changes label Oct 23, 2020
@javascript-translate-bot javascript-translate-bot requested a review from a team October 23, 2020 21:36
@CLAassistant
Copy link

CLAassistant commented Oct 23, 2020

CLA assistant check
All committers have signed the CLA.

@danipoma danipoma changed the title Translation of 1-js/01-getting-started/1-intro cs-CZ translation of 1-js/01-getting-started/1-intro Oct 23, 2020
@iliakan
Copy link
Member

iliakan commented Oct 23, 2020

Please ask the maintainer, is he alive? :) If he isn't then tell me.

@danipoma danipoma changed the title cs-CZ translation of 1-js/01-getting-started/1-intro An Introduction to JavaScript Oct 23, 2020
@danipoma danipoma closed this Oct 23, 2020
@otmon76
Copy link
Contributor

otmon76 commented Oct 23, 2020

Hello,
I am alive. I am sorry but I thought that other users must ask me before starting translation. I will talk with danipoma.

@danipoma danipoma deleted the translate branch October 23, 2020 22:05
@iliakan
Copy link
Member

iliakan commented Oct 23, 2020

@otmon76 great to hear from you.

Anyone is free to contribute, unless someone else took the article for the translation.

As the maintainer, I assume you have enough JS knowledge to review the translations?

I hope to see the Czech translation going ahead =)

@danipoma
Copy link
Contributor Author

@otmon76 How exactly are we going to talk this through? Once again I am sorry for my missing knowledge about git and getting info about it. I have deleted this pull request, because at first I thought that this project didn't start just yet, but then I found that there actually is a list of articles for taking and this one was already in progress on your side.

What is the workflow? Can I help you with translation? How can I reserve that article in issue list? Is there any standard on which you should create PR like should I create PR to javascript-tutorial repo when I have more articles translated on my repo or should I create PR per each document?

Thank you for information.

@otmon76
Copy link
Contributor

otmon76 commented Oct 23, 2020

I am sorry. I don't know Github too much yet and I didn't notice that I must commit my pull requests here, not to my branch. Each article must be reviewed by 2 users before publishing. I have translated first 2 chapters but I need reviewers and nobody was interested yet, so I didn't commit them yet.

Also I would like to ask you: would you want to take the administration from me? If you are interested please contact me at [email protected].

@danipoma
Copy link
Contributor Author

Nothing to be sorry about, I just skimmed few articles today to be able to push changes. You can push changes to remote repo of your clone and then promote them to origin repo you cloned, for more info look on some article.

Regarding that administration thing. I don't know how much active I will be as well, but I could try it.
I will contact you on your e-mail as well.

Best Regards.

@iliakan
Copy link
Member

iliakan commented Oct 24, 2020

@otmon76 if @danipoma translation is good, I can add him to maintainers.

Also, 2 reviewers per article is a recommendation, not a strict rule.

@danipoma
Copy link
Contributor Author

danipoma commented Oct 24, 2020

Hello @iliakan
@otmon76 and I discussed through e-mail correspondence that it would be for the best if you would promote me to maintainer status as well, it would be for the best @otmon76, if you would confirm my statement.

Regarding that 2 reviewers rule is probably not going to fare well at least for now, because only I and @otmon76 is somewhat interested in translating this guide,

Regardless of our current translation status, I also wanted to say that I really appreciate this guide, because of its structure and how topics are presented and overall just how digestible that content is. I firmly believe that if we want to have more developers, we need to make tools like (digestible, easy to use, intuitive, out-of-the-box experience) this to support them in their learning curve. I believe that things like javascript.info, caniuse.com, codesandbox.io, devdocs.io, MDN, regex101.com, freecodecamp etc. are all things that play a major role in developer's development.

@iliakan
Copy link
Member

iliakan commented Oct 24, 2020

Done!

@danipoma danipoma removed the review needed Review needed, please approve or request changes label Oct 24, 2020
@danipoma danipoma changed the title An Introduction to JavaScript An Introduction to JavaScript, deleted due to duplicate work Oct 24, 2020
@danipoma danipoma changed the title An Introduction to JavaScript, deleted due to duplicate work An Introduction to JavaScript, rejected due to duplicate work Oct 24, 2020
www-learn-en pushed a commit that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants