Allow all shardings if exported.nr_devices is 1 in _export.py.
#29690
+59
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_775223333
branch
2 times, most recently
from
7ae8a67 to
e75e1a8
Compare
If `exported.nr_devices == 1`, any sharding is equivalent to replicated sharding. The sharding in the exported function is meaningless. We also update test cases, where * meshes of size 1 and n can share the same exported module * meshes of size 2 and n cannot share the same exported module PiperOrigin-RevId: 775560222
copybara-service
bot
force-pushed
the
test_775223333
branch
from
e75e1a8 to
67bf78a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow all shardings if
exported.nr_devicesis 1 in_export.py.If
exported.nr_devices == 1, any sharding is equivalent to replicated sharding. The sharding in the exported function is meaningless.We also update test cases, where