Skip to content

Allow regexp_parser 2.0 #11

Closed
Closed
@tagliala

Description

@tagliala

There are 4 failures about multiple quantifiers:

Failures:

  1) JsRegex::Converter::Base#convert when there are multiple quantifiers drops adjacent/multiplicative fixes ({x}) without warning
     Failure/Error:
       expect(/a{4}{6}/).to\
       become(/a{6}/)
     
       expected a{6}, got (?:a{4}){6}
     # ./spec/lib/js_regex/converter/base_spec.rb:165:in `block (4 levels) in <top (required)>'

  2) JsRegex::Converter::Base#convert when there are multiple quantifiers drops adjacent/multiplicative ranges ({x,y}) without warning
     Failure/Error:
       expect(/a{2,4}{3,6}/).to\
       become(/a{3,6}/)
     
       expected a{3,6}, got (?:a{2,4}){3,6}
     # ./spec/lib/js_regex/converter/base_spec.rb:170:in `block (4 levels) in <top (required)>'

  3) JsRegex::Converter::Base#convert when there are multiple quantifiers drops mixed adjacent quantifiers without warning
     Failure/Error:
       expect(/ab{2,3}*/).to\
       become(/ab*/)
     
       expected ab*, got a(?:b{2,3})*
     # ./spec/lib/js_regex/converter/base_spec.rb:175:in `block (4 levels) in <top (required)>'

  4) JsRegex::Converter::Base#convert when there are multiple quantifiers drops multiple adjacent quantifiers without warning
     Failure/Error:
       expect(/ab{2}{3}{4}{5}/).to\
       become(/ab{5}/)
     
       expected ab{5}, got a(?:(?:(?:b{2}){3}){4}){5}
     # ./spec/lib/js_regex/converter/base_spec.rb:180:in `block (4 levels) in <top (required)>'

Finished in 0.81114 seconds (files took 0.2056 seconds to load)
297 examples, 4 failures

Failed examples:

rspec ./spec/lib/js_regex/converter/base_spec.rb:164 # JsRegex::Converter::Base#convert when there are multiple quantifiers drops adjacent/multiplicative fixes ({x}) without warning
rspec ./spec/lib/js_regex/converter/base_spec.rb:169 # JsRegex::Converter::Base#convert when there are multiple quantifiers drops adjacent/multiplicative ranges ({x,y}) without warning
rspec ./spec/lib/js_regex/converter/base_spec.rb:174 # JsRegex::Converter::Base#convert when there are multiple quantifiers drops mixed adjacent quantifiers without warning
rspec ./spec/lib/js_regex/converter/base_spec.rb:179 # JsRegex::Converter::Base#convert when there are multiple quantifiers drops multiple adjacent quantifiers without warning

May refer to: e3da3f3

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions