Skip to content

Add support to TLS #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
moisesguimaraes opened this issue Nov 20, 2019 · 6 comments
Closed

Add support to TLS #207

moisesguimaraes opened this issue Nov 20, 2019 · 6 comments

Comments

@moisesguimaraes
Copy link
Contributor

Since version 1.5.13, Memcached supports TLS.

Motivation

At OpenStack, we use python-binary-memcached in one of our oslo.cache Memcache backend drivers. To accommodate some cloud security requirements, we will need to enable TLS in Memcached as data must be encrypted in the wire in some scenarios.

I looked over the documentation and couldn't find anything related to TLS support. If there is a way to achieve that, please let us know.

I would like to help with the implementation of this if needed.

@jaysonsantos
Copy link
Owner

Hey there, right now there is no TLS support.
I didn't read how TLS support is implemented on the binary protocol but I assume it would be just a matter of wrapping the inner socket with a TLS context?
I would be greatly appreciated if you could submit a PR for this.

@moisesguimaraes
Copy link
Contributor Author

Yeah, I got to that line yesterday. Today I'm on PTO but I plan to do it on Monday.

[OFF TOPIC] and... are you Brazilian? [/OFF TOPIC]

@jaysonsantos
Copy link
Owner

Hey @moisesguimaraes thanks for the help!
Yes, I am brazilian :)

@moisesguimaraes
Copy link
Contributor Author

Cool, I got some changes working locally, now I'm trying to figure out how to get it covered by tests.

Would you like me to create a PR already and then we can iterate over it?

@jaysonsantos
Copy link
Owner

Hey, sorry for the delay.
Yes with the PR we can talk abou what you are doing.

@moisesguimaraes
Copy link
Contributor Author

TLS support added in #211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants