Prevent "Unknown app_id" crashes #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Appium / instruments was sending a new message that wasn't handled previously, applicationUpdated. It seems to be changing one PID to a new PID, so we remove the old PID from the hash table, and insert the new one.
Skipping print statement that segfaults
Trying to swap the two app_ids to fix error. Cleaned up iwdp_on_applicationUpdated()
applicationSentListing would often error out with Unknown app [app_id] since connectedApplications would be sent an empty list of connected apps. Thus, all apps were removed from the hash table, even though automated testing was going on. This isn't particularly pretty work around for automated testers, but outside of long stress tests of multiple apps, this should be no issue
applicationSentListing is invoked when tab is changed. Sometimes there can be situation when the tab's app id is not in the hash table It can occur when Safari was in background when proxy was launched or Safari goes into background and comes back again (SafariLauncher). When such situation occur just ignore the update and don't crash the proxy
|
Sorry I haven't replied to this yet. I think that this method is a bit heavy handed in the solution, basically chucking out any sort of errors and assume it's fine... I think most people will find this is a good enough solution that will solve most issues for the future due to plist changes but of course there might be an actual issue that arises and is simply passed off with this patch. I will mull it over for a bit, maybe you can put this PR on the Google repository instead and see what other's think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
applicationSentListing is invoked when tab is changed. Sometimes there can be situation when the tab's app id is not in the hash table
It can occur when Safari was in background when proxy was launched or Safari goes into background and comes back again (SafariLauncher).
When such situation occur just ignore the update and don't crash the proxy