Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a companion PR for teamwalnut/graphql-ppx#175.
That PR makes it possible for hooks and client methods now accept
t_variables
instead ofRaw.t_variables
. The advantage of this is that records can be the primary way of passing variables andmakeVariables
is a convenience function for when you want to only pass a few optional variables. UsingRaw. t_variables
before allowed you to explicitly pass null arguments, however. To accommodate this, you can now pass amapNullVariables
(name?) function to anything that takest_variables
. Something like this:I'm only really concerned with being able to pass
t_variables
at the call site, so everywhere else things are typed asRaw.t_variables
. I think that's fine and perhaps even preferable in some cases.